Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yield details always, no need to check for SCA eligibility #13141

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Yield details always, no need to check for SCA eligibility #13141

merged 1 commit into from
Nov 21, 2023

Conversation

ogajduse
Copy link
Member

Problem Statement

Solution

  • yield details
  • remove SCA eligibility check

@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Nov 21, 2023
@ogajduse ogajduse self-assigned this Nov 21, 2023
@ogajduse ogajduse requested a review from a team as a code owner November 21, 2023 10:58
JacobCallahan
JacobCallahan approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job tracking down the BZ for simplified behavior!

@ogajduse
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_erratum_applicability tests/foreman/cli/test_host.py::test_syspurpose_end_to_end

@lpramuk
Copy link
Contributor

lpramuk commented Nov 21, 2023

Nice job tracking down the BZ for simplified behavior!

Indeed.
Suggested by me 😉

@ogajduse
Copy link
Member Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_erratum_applicability tests/foreman/cli/test_host.py::test_syspurpose_end_to_end

@ogajduse
Copy link
Member Author

test_syspurpose_end_to_end[rhel7_contenthost0] failed, but the failure is unrelated to my changes since this test does not use the setup_custom_repo fixture.
Ready for merge from my PoV.

@lpramuk lpramuk merged commit e39ce21 into SatelliteQE:master Nov 21, 2023
8 of 9 checks passed
This was referenced Nov 21, 2023
Merged
Merged
@ogajduse ogajduse deleted the fix/sca-eligibility-yield-details branch November 21, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpramuk lpramuk lpramuk approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@ogajduse ogajduse

Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogajduse @lpramuk @JacobCallahan